Hi Gary!
Thanks for posting your fixes. I just wanted to confirm placement on the
change to the Client.pm:
Old:
my $self = shift;
my $data = shift;
my %params = @_;
if ($params{custom_tech_contact}) {
$contact_types{tech} = "Tech";
}
#XXX validate the nameservers
####################################
# check the required fields
New:
my $self = shift;
my $data = shift;
my %params = @_;
if ($params{custom_tech_contact}) {
$contact_types{tech} = "Tech";
}
if ($params{custom_nameservers} &&
$data->{reg_type} eq "new") {
#XXX validate the nameservers
if (!$data->{fqdn1}) {
push @missing_fields, "Primary DNS Hostname";
}
if (!$data->{fqdn2}) {
push @missing_fields, "Secondary DNS Hostname";
}
}
####################################
# check the required fields
-----Original Message-----
From: owner-dev-list@opensrs.org [mailto:owner-dev-list@opensrs.org]On
Behalf Of Gregory Neil Shapiro
Sent: Wednesday, July 19, 2000 2:48 AM
To: dev-list@opensrs.org; support@opensrs.org
Subject: Some minor bugs in 2.0.X
Some of these are minor, but all are easy to fix:
1. doc/return_codes.txt is missing the 'lookup' 210 and 211 result codes.
2. The <font face="verdana, arial" size=1> and <font size=1> is difficult
to read on UNIX Netscape 4.X. Changing all of the size=1 to size=2 in
manage.cgi and templates/manage/* make customers much happier.
3. reg_system:verify_order() shouldn't show the nameservers on transfers.
Changing:
# encode the nameserver info and pass it to the next form
if ($custom_nameservers) {
foreach $num (1..6) {
to:
# encode the nameserver info and pass it to the next form
if ($custom_nameservers &&
$in{reg_type} eq "new") {
foreach $num (1..6) {
fixes the problem.
4. In reg_system:build_nameservers(), the Third through Sixth DNS Hostnames
should be marked "<font color=red size=-1>*optional*</font>" for
consistency with other optional fields in the form.
5. OpenSRS/Client.pm:validate() should at least verify two nameservers were
given:
if ($params{custom_nameservers} &&
$data->{reg_type} eq "new") {
#XXX validate the nameservers
if (!$data->{fqdn1}) {
push @missing_fields, "Primary DNS Hostname";
}
if (!$data->{fqdn2}) {
push @missing_fields, "Secondary DNS Hostname";
}
}
This archive was generated by hypermail 2.1.3 : Tue Oct 19 2004 - 23:35:41 EDT